D9568: Add a way to reset changes to system-wide color schemes

[Kurt Hindenburg]

hindenburg added a comment.


  Can you update the patch fixing my comments and updating your master branch - I've made some changes since this patch - although it applies cleanly

INLINE COMMENTS

> ColorSchemeManager.cpp:226
> +            return dirInfo.isWritable();
> +        } else {
> +            return true;

minor - align indents

> ColorSchemeManager.h:95
> +     */
> +    bool canResetColorScheme(const QString &name);
> +

If possible, use API doxygen labels - here for example use @p name to explain how name is used.

> EditProfileDialog.h:135
>      void removeColorScheme();
> +    // overwrites a colorscheme in ~/.loca/share/konsole with the respective
> +    //original colorscheme from /usr/share/konsole/

You're actually deleting the file in .local/share - not overriding it.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D9568

To: ahmadsamir, hindenburg, #konsole
Cc: #konsole, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180121/9f2084fa/attachment-0001.html>