D10862: Konsole: Add read-only mode
Joshua Noack
noreply at phabricator.kde.org
Tue Feb 27 23:54:39 UTC 2018
jnoack planned changes to this revision.
jnoack added a comment.
In D10862#214408 <https://phabricator.kde.org/D10862#214408>, @ngraham wrote:
> Putting on my VDG hat: we definitely need a visible UI during read-only mode that tells you that the terminal is read-only, or else there is a near-100% chance that people will file bugs after they turn on read-only mode by accident or forget that it's on.
>
> Konsole already shows a yellow-colored contextual bar that appears near the top of the window in various other contexts; maybe we could re-use that here?
Konsole uses a QLabel to show the bar at the top, which isn't resuable at all without refactoring (I refer to the bar which pops up when CTRL+S is pressed).
Instead I tried to use the KMessageWidget, which looks quite ok imo:
F5733073: Screenshot_20180228_004027.png <https://phabricator.kde.org/F5733073>
What do you think? Furthermore, once this is ready I would like to port the QLabel-"bar" to the KMessageWidget in another revision as well if nothing speaks against it. Then I can share most of the code.
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D10862
To: jnoack
Cc: ngraham, #konsole, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180227/3f828bbc/attachment.html>
More information about the konsole-devel
mailing list