D10766: add knewstuff support for color schemes

Harald Sitter noreply at phabricator.kde.org
Fri Feb 23 12:47:32 UTC 2018


sitter created this revision.
sitter added a reviewer: hindenburg.
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.
sitter requested review of this revision.

REVISION SUMMARY
  - new manager helpers to unload a theme and check a file's name validity
  - new Get New.. button to start the KNS download dialog
  - upon KNS completion we'll attempt to load all installed files as schemes
  - for KNS entities which failed to load anything we'll show a warning as the theme is malformed
  - for removal we'll first try to remove schemes through KNS to avoid its registry going out of sync with the on-disk "installedness" of an entity
  - properly disable copying of the scheme manager (needs to be private)
  
  FEATURE: 18.04.0
  CHANGELOG: Support for downloading color schemes from the KDE store

TEST PLAN
  category doesn't exist yet (T8053 <https://phabricator.kde.org/T8053>) `KDE Color Scheme KDE4` can be used in combination with searching for `konsole`.
  
  - get new -> install scheme -> close -> shows up in list
  - remove from list -> get new -> not listed as installed
  - install random stuff from kde color scheme category -> close -> warning should be displayed
  - install scheme -> get new -> remove scheme via dialog -> close -> not listed as installed

REPOSITORY
  R319 Konsole

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10766

AFFECTED FILES
  CMakeLists.txt
  data/CMakeLists.txt
  data/konsole.knsrc
  src/CMakeLists.txt
  src/ColorSchemeManager.cpp
  src/ColorSchemeManager.h
  src/EditProfileDialog.cpp
  src/EditProfileDialog.h
  src/EditProfileDialog.ui

To: sitter, hindenburg
Cc: #konsole, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180223/c32cef0c/attachment.html>


More information about the konsole-devel mailing list