[konsole] [Bug 389864] git tagging issues

[RJVB]

https://bugs.kde.org/show_bug.cgi?id=389864

RJVB <rjvbertin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |REMIND
             Status|RESOLVED                    |CLOSED

--- Comment #9 from RJVB <rjvbertin at gmail.com> ---
You really need to stop trolling here if you don't want to be part of the
discussion. You don't agree, fine, that makes this a matter between the Konsole
authors and me, and unsubscribing you is nothing more than an attempt at
preserving your so precious time. Please stay out of the discussion from now
on.

> 18.03.70 is a "developing version", it doesn't exist, so there can't be a tag 
> for it, tags are "a fixed point in the code when a version was set",

Wrong, there's a clear point where the project started reporting version
18.03.70 , and it's not just in my imagination that this called a version:

commit 7f7ed40d1ca6d8578bd41dc3199ce3d68a05a667 (tag: v18.03.70)
Author: Albert Astals Cid <aacid at kde.org>
Date:   Mon Nov 13 08:59:20 2017 +0100

    GIT_SILENT Upgrade KDE Applications version to 18.03.70.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 02f5e82a..5f3e1a8f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,8 +1,8 @@
 # Konsole project

 # KDE Application Version, managed by release script
-set (KDE_APPLICATIONS_VERSION_MAJOR "17")
-set (KDE_APPLICATIONS_VERSION_MINOR "11")
+set (KDE_APPLICATIONS_VERSION_MAJOR "18")
+set (KDE_APPLICATIONS_VERSION_MINOR "03")
 set (KDE_APPLICATIONS_VERSION_MICRO "70")
 set (KDE_APPLICATIONS_VERSION
"${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}")

There isn't a more "fixed point in code" that represents 17.12.1 or any other
released version: a version upgrade is always a single point in time regardless
whether it's a release or a development version.

I don't care what form tags take, so there must be any number of ways project
authors can tag branches which are not used in the release "story" without
causing confusion there, and while still keeping a logical link between a given
point in the commit history and a version reported from inside the application.
Ideally the application would report a more fully qualified version itself that
indicates from which snapshot it was built, but that's a separate issue (cf.
patch review D8158). Being able to put a local version on your install or
packaging that's based on a version obtained directly from git is the next best
solution.

So, Konsole author(s): please consider adding a master branch tag for
18.04.whatever whenever that "version" appears and if necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.