[konsole] [Bug 402452] Crash in Konsole::TerminalDisplay::extendSelection after 4e09f089f940335bdd628139e870ba99721fddfa

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=402452

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kon |https://commits.kde.org/kon
                   |sole/b85bbaa8c8807ab3619cdd |sole/ef3773b8753b7553fc09c8
                   |c35b634c2bb43e09fb          |cb020925388b05bc73

--- Comment #5 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit ef3773b8753b7553fc09c8cb020925388b05bc73 by Kurt Hindenburg, on
behalf of Pavel Khlebovich.
Committed on 30/12/2018 at 04:00.
Pushed by hindenburg into branch 'Applications/18.12'.

Fix crash in extendSelection

Summary:
Fix crash when doing word selection or line selection
and moving the cursor to the end of the screen.
After 4e09f089f940335bdd628139e870ba99721fddfa
Konsole tries to read out of bounds when you double
click to select a whole empty line, and hold down the
mouse button and drag to the right.

Note: still crashes with on some extendSelections
such when y=-1

Test Plan:
Doesn't crash anymore, selecting the last column works,
both in normal selection, line selection and word selection.

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Differential Revision: https://phabricator.kde.org/D17757

(cherry picked from commit b85bbaa8c8807ab3619cddc35b634c2bb43e09fb)

M  +7    -1    src/TerminalDisplay.cpp

https://commits.kde.org/konsole/ef3773b8753b7553fc09c8cb020925388b05bc73

-- 
You are receiving this mail because:
You are the assignee for the bug.