D17374: Profile shortcuts switch profile instead of opening new tab

[Kurt Hindenburg]

hindenburg added a comment.


  Can you look the change I requested - a quick coding here seems to work w/ the changes.

INLINE COMMENTS

> SessionController.cpp:226
> +
> +    _profileList = ((ViewManager *)this->parent())->getProfileList();
> +    connect(_profileList, &ProfileList::actionsChanged, this, &Konsole::SessionController::prepareSwitchProfileMenu);

This isn't good; instead of putting getProfileList() in ViewManager, put it in ProfileManager (without QObject) and then do '_profileList = ProfileManager::instance()->getProfileList();
'

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17374

To: thsurrel, #konsole, hindenburg, tcanabrava
Cc: loh.tar, konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181230/17db06bf/attachment.html>