D17588: MainWindow: Add Frameless option

Kurt Hindenburg noreply at phabricator.kde.org
Sat Dec 29 22:38:47 GMT 2018


hindenburg added inline comments.

INLINE COMMENTS

> MainWindow.cpp:827
> +
> +    if (oldVisibility & !isVisible()) {
> +        setVisible(true);

while this works for bool, I'd rather use && here - I'll commit some changes after this.

REPOSITORY
  R319 Konsole

BRANCH
  correction

REVISION DETAIL
  https://phabricator.kde.org/D17588

To: patrickelectric, #konsole, hindenburg
Cc: sandsmark, tcanabrava, konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181229/7304dc8a/attachment.html>


More information about the konsole-devel mailing list