[konsole] [Bug 401864] Don't use Konsole icon as default profile icon

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=401864

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/e1fde67a69c748b76f8210
                   |                            |ac22f58e76b53d9717
   Version Fixed In|                            |19.04.0

--- Comment #2 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit e1fde67a69c748b76f8210ac22f58e76b53d9717 by Kurt Hindenburg, on
behalf of Nate Graham.
Committed on 28/12/2018 at 03:27.
Pushed by hindenburg into branch 'master'.

Only show tab icon if the user has specifically chosen one

Summary:
This patch introduces a UI change: tabs only show an icon if it's not
the default one; that is to say, only if the user has actually customized
the icon. There are several reasons for this:
1. **Conceptual:** When only non-default profile icons show up in the tab,
  it does a better job of highlighting the fact that a non-default profile
  is being used.
2. **Aesthetic:** you no longer have the same icon in every tab by default,
  which looks bad and causes the eye to ignore it over time.
3. **Icon-specific:** the `utilities-terminal` icon doesn't look good
  against a dark background (https://bugs.kde.org/show_bug.cgi?id=367696)
4. **Code hygiene:** reduces a bit of redundancy in the session controller
   code.
Related: bug 367696
FIXED-IN: 19.04.0

Test Plan:
Open multiple tabs and make one of them use a profile with a
non-default icon:
{F6502534, size=full}

Verify that bell signals still cause tabs to get icons.

Reviewers: #konsole, #vdg, ndavis, hindenburg

Reviewed By: #konsole, #vdg, ndavis, hindenburg

Subscribers: fabianr, abetts, hindenburg, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D17747

M  +9    -7    src/SessionController.cpp

https://commits.kde.org/konsole/e1fde67a69c748b76f8210ac22f58e76b53d9717

-- 
You are receiving this mail because:
You are the assignee for the bug.