D17814: Added button to close the tab individually

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Actually, now that I apply this, I don't see any new files being created, so sorry about the comment.
  
  Functionally, it works fine! UI-wise, I think we need to change a few things. The current UI is a bit off:
  
  F6512005: Screenshot_20181227_125033.png <https://phabricator.kde.org/F6512005>
  
  I feel fairly strongly that this should not be an option and when close buttons are shown, they should //always// be on the tab rather than on the bar. But if this is just too controversial, the following UI would be an improvement:
  
    New Tab button: [ ] Show
     Close buttons: (o) On each tab
                    ( ) On the tab bar
                    ( ) None
  
  If it's absolutely imperative that a single checkbox control both the new tab and close button visibility, then we could do the following:
  
    [] Show 'New Tab' and 'Close Tab' Buttons
        Close buttons: (o) On each tab
                       ( ) On the tab bar
  
  ...And the radio buttons would only be enabled when the checkbox above them was checked.
  
  But again, I think it would be best to always show the close buttons on the individual tabs when close buttons are visible.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17814

To: marssola, tcanabrava, #vdg, #konsole, ngraham
Cc: abetts, ngraham, hindenburg, konsole-devel, thsurrel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181227/54d0a147/attachment.html>