D17744: New search result look, resurrected

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  In D17744#381034 <https://phabricator.kde.org/D17744#381034>, @mglb wrote:
  
  > 1.
  >   - Invoke search, type text: all nice, I see current search line and remaining search results
  >   - Close search
  >   - Invoke search again: There is no current line (this is OK) and no dim (not OK) - search results are barely visible (without transparency they are not visible at all)
  
  
  Fixed. But because we don't have any other way of indicating whether the search is active other than setting the current result line being valid I solved it by preserving the current search line (which makes more sense anyhow, imho).
  
  > 2. Font size change (Ctrl+Scroll, Ctrl++, Ctrl+-) during search is not handled
  
  Not sure what you mean, it seems to work here.
  
  > Pedantic things:
  > 
  > - Selecting search result removes the rounded rect's rounding F6502287: rounded-corners.png <https://phabricator.kde.org/F6502287>
  
  I explicitly didn't change this, to indicate clearly that it is selected, even when searching.
  
  > - What do you think about making the lines 1px tall, drawn on inner edge of the rectangle? This would match lines in Breeze widget style.
  
  Not entirely sure what you mean.
  
  > - Configurable colors, or colors taken from system theme/konsole theme
  
  Tested this a bit first, but it's hard to make it work with all kinds of different application (`make menuconfig` is what broke it for me, but mc etc. is also good at breaking this).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17744

To: sandsmark, hindenburg, #konsole, thsurrel, tcanabrava, #vdg
Cc: ngraham, mglb, konsole-devel, #konsole, thsurrel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181225/d1873570/attachment.html>