D17759: Correct includes

Kurt Hindenburg noreply at phabricator.kde.org
Mon Dec 24 15:33:00 GMT 2018


hindenburg added a comment.


  Only one question - otherwise looks fine

INLINE COMMENTS

> SessionController.h:25
>  // Qt
> -#include <QList>
>  #include <QSet>

This is the only concern I see - it compiles because it it pulling QList from the ProfileManager.h include - shouldn't the QList include be moved to SessionController.cpp ?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17759

To: patrickelectric, tcanabrava, hindenburg, #konsole
Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181224/16178312/attachment.html>


More information about the konsole-devel mailing list