D17747: Only show tab icon if the user has specifically chosen one
Kurt Hindenburg
noreply at phabricator.kde.org
Sun Dec 23 18:45:23 GMT 2018
hindenburg added a comment.
I don't see any issues - tested w/ monitor for silence/activity works as before. The tabs look odd to me w/o any icon but that's likely just due I'm used to seeing them.
INLINE COMMENTS
> SessionController.cpp:1531
> + if (_session->iconName() == QStringLiteral("utilities-terminal")) {
> + _sessionIconName = QStringLiteral("");
> + } else {
For empty strings use QString()
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D17747
To: ngraham, #konsole, #vdg, ndavis
Cc: hindenburg, konsole-devel, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181223/9a2a6760/attachment.html>
More information about the konsole-devel
mailing list