D17747: Only show tab icon if the user has specifically chosen one

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Konsole, VDG, ndavis.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch introduces a UI change: tabs only show an icon if it's not the default one; that is to say, only if the user has actually customized the icon. There are two primary reasons for this:
  
  1. Conceptual: When onlly non-default profile icons show up in the tab, it does a better job of highlighting the fact that a non-default profile is being used.
  2. Aesthetic: you no longer have the same icon in every tab by default, which looks bad and causes the eye to ignore it over time.
  3. Icon-specific: the `utilities-terminal` icon doesn't look good against a dark background.
  
  BUG: 401864
  FIXED-IN: 19.04.0

TEST PLAN
  Open multiple tabs and make one of them use a profile with a non-default icon:
  [image goes here]
  
  Verify that bell signals still cause tabs to get icons.

REPOSITORY
  R319 Konsole

BRANCH
  only-show-customized-tab-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17747

AFFECTED FILES
  src/SessionController.cpp

To: ngraham, #konsole, #vdg, ndavis
Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181223/e4b6c7ab/attachment-0001.html>