D17492: Be explicit on what the ViewContainer accepts

[Kurt Hindenburg]

hindenburg added a comment.


  I'll see if I find anything after testing

INLINE COMMENTS

> ViewContainer.cpp:90
>      connect(tabBarWidget, &DetachableTabBar::detachTab, this, [this](int idx) {
> -        emit detachTab(this, widget(idx));
> +        emit detachTab(this, qobject_cast<TerminalDisplay*>(widget(idx)));
>      });

Why not use terminalAt() here?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17492

To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181212/013ddecb/attachment.html>