D17492: Be explicit on what the ViewContainer accepts
Tomaz Canabrava
noreply at phabricator.kde.org
Mon Dec 10 17:29:15 GMT 2018
tcanabrava created this revision.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
tcanabrava requested review of this revision.
REVISION SUMMARY
This is needed to clean up a bit of the code later.
being really explicit here removes the need to handle
QWidget pointers, as that could in theory be anything
Handling only TerminalDisplays* we can remove the
SessionController map from the ViewContainer and
add it to the TerminalDisplay class in the future
REPOSITORY
R319 Konsole
BRANCH
explicitTypes
REVISION DETAIL
https://phabricator.kde.org/D17492
AFFECTED FILES
src/ViewContainer.cpp
src/ViewContainer.h
src/ViewManager.cpp
To: tcanabrava
Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181210/8016feca/attachment.html>
More information about the konsole-devel
mailing list