D17485: Remove three classes form the SessionController header/source

Tomaz Canabrava noreply at phabricator.kde.org
Mon Dec 10 15:53:31 GMT 2018


tcanabrava created this revision.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Those three classes where *used* inside of the SessionController
  but they where not supposed to be there. The code in the
  SessionController is already too big to understand, so the removal
  of unrelated code is a good thing: it's now easier to reason
  about those other three classes without having to deal with
  the whole code that the SessionController has.

REPOSITORY
  R319 Konsole

BRANCH
  separateClasses

REVISION DETAIL
  https://phabricator.kde.org/D17485

AFFECTED FILES
  src/CMakeLists.txt
  src/SaveHistoryTask.cpp
  src/SaveHistoryTask.h
  src/SearchHistoryTask.cpp
  src/SearchHistoryTask.h
  src/SessionController.cpp
  src/SessionController.h
  src/SessionTask.cpp
  src/SessionTask.h

To: tcanabrava
Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181210/7b5c9fb6/attachment-0001.html>


More information about the konsole-devel mailing list