[konsole] [Bug 385697] New session in split view

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=385697

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |19.04
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/7a43e3b2cde05a70a38c0b
                   |                            |cac39051b675425bf9
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 7a43e3b2cde05a70a38c0bcac39051b675425bf9 by Kurt Hindenburg, on
behalf of Tomaz Canabrava.
Committed on 10/12/2018 at 15:02.
Pushed by hindenburg into branch 'master'.

Don't duplicate the tabs when Spliting the View

Summary:
Instead of iterating over the sessions to fetch the view and
duplicate the current screen once for each split, ignore all
of them and just create a new terminal view. The only thing
this terminal view shares with the previous current widget
is the profile.

use createView instead of manually trying to create the view

Fixes bug while closing the split

Don't duplicate tabs in the splits
Related: bug 380455
FIXED-IN: 19.04

Reviewers: thsurrel, hindenburg, gennad, ngraham, #konsole

Reviewed By: thsurrel, hindenburg, ngraham, #konsole

Subscribers: ngraham, hindenburg, gennad, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D17267

M  +11   -9    src/Application.cpp
M  +20   -21   src/MainWindow.cpp
M  +7    -4    src/MainWindow.h
M  +3    -4    src/Part.cpp
M  +6    -0    src/TerminalDisplay.cpp
M  +13   -19   src/ViewContainer.cpp
M  +4    -5    src/ViewContainer.h
M  +35   -71   src/ViewManager.cpp
M  +9    -5    src/ViewManager.h
M  +12   -0    src/ViewSplitter.cpp

https://commits.kde.org/konsole/7a43e3b2cde05a70a38c0bcac39051b675425bf9

-- 
You are receiving this mail because:
You are the assignee for the bug.