D17294: Add special support for block characters

Kurt Hindenburg noreply at phabricator.kde.org
Fri Dec 7 15:26:15 GMT 2018


hindenburg added inline comments.

INLINE COMMENTS

> TerminalDisplay.cpp:937
>          const uchar code = str[i].cell();
> -        if (LineChars[code] != 0u) {
> +        if (code > 0x7F) {
> +            drawBlockChar(painter, x + (_fontWidth * i), y, _fontWidth, _fontHeight, code);

does it make sense here to add an upper bound to make this clearer?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17294

To: sandsmark, #konsole, hindenburg
Cc: konsole-devel, #konsole, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181207/be399c9f/attachment.html>


More information about the konsole-devel mailing list