D17329: Simplify/Speedup reading Stylesheet file

[Tomaz Canabrava]

That makes sense if you are processing the line and doing something with it
and discarding, but not appending to a string doing nothing with it until
the result is the whole file content. If what you want is the same as the
readAll, this one is faster as there’s no allocations for the temporary.

Em ter, 4 de dez de 2018 às 02:50, Kurt Hindenburg <
noreply at phabricator.kde.org> escreveu:

> hindenburg added a comment. View Revision
> <https://phabricator.kde.org/D17329>
>
> Ok, I think I/someone read the docs and did it that way from the start - I
> wonder what the Qt docs thinks is a large file.
> ------------------------------
>
> Reads the entire content of the stream, and returns it as a QString. Avoid
> this function when working on large files, as it will consume a significant
> amount of memory.
>
> Calling readLine() is better if you do not know how much data is available.
>
> *REPOSITORY*
> R319 Konsole
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D17329
>
> *To: *tcanabrava, hindenburg
> *Cc: *konsole-devel, ngraham, maximilianocuria, hindenburg
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181204/a2f128fe/attachment.html>