D17244: Edit Profile Dialog UI redesign

[Mariusz Glebocki]

mglb updated this revision to Diff 46816.
mglb added a comment.


  Thanks!
  
  All suggestions applied. However, I think the "Blinking" checkbox looks a bit weird without the right label:
  
  F6453561: Screenshot_2018-12-04-00-16-29.png <https://phabricator.kde.org/F6453561>
  
  Like, something is missing there visually.
  
  @rizzitello thanks, bug fixed. Signal-slot connections were created on each tab change.

REPOSITORY
  R319 Konsole

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17244?vs=46506&id=46816

BRANCH
  arc/Edit-Profile-Dialog-UI-redesign (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17244

AFFECTED FILES
  src/CMakeLists.txt
  src/CharacterColor.h
  src/EditProfileAdvancedPage.ui
  src/EditProfileAppearancePage.ui
  src/EditProfileDialog.cpp
  src/EditProfileDialog.h
  src/EditProfileDialog.ui
  src/EditProfileGeneralPage.ui
  src/EditProfileKeyboardPage.ui
  src/EditProfileMousePage.ui
  src/EditProfileScrollingPage.ui
  src/EditProfileTabsPage.ui
  src/FontDialog.cpp
  src/FontDialog.h
  src/HistorySizeDialog.cpp
  src/HistorySizeDialog.h
  src/HistorySizeDialog.ui
  src/HistorySizeWidget.cpp
  src/HistorySizeWidget.h
  src/HistorySizeWidget.ui
  src/RenameTabDialog.ui
  src/RenameTabWidget.ui

To: mglb, #konsole, #vdg
Cc: rizzitello, abetts, ngraham, konsole-devel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181203/ddd1e489/attachment-0001.html>