D12554: Fix cursor advancement in last column

[Mariusz Glebocki]

mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Until now, the cursor was moved from last column to the next column
  outside the screen. Since screen array is linear, it partially worked
  like it was on the beginning of a next line (as long as it was not the
  last line).

TEST PLAN
  - Run `cat > /dev/null` (shells do their own line wrapping, so will not work)
  - Move cursor to terminal's last visible line using enter
  - Move cursor to terminal's last visible column by typing something
  - Type one more character
  
  Expected resul: new line should appear with the cursor on the beginning
  Actual result: cursor disappears, no new line
  
  - Turn on blinking cursor
  - Run `cat > /dev/null`
  - Move cursor to terminal's last visible column by typing something
  - Type one more character
  
  Expected result: the cursor should move to new line's first column
  
    and blink
  
  Actual result: the cursor "moves" but does not blink

BRANCH
  wip/cursor-fixes/0003-Fix-cursor-advancement-in-last-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12554

AFFECTED FILES
  src/Screen.cpp

To: mglb, #konsole
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180426/a87a522f/attachment.html>