D12236: Change internal character type size to 32 bit

[Mariusz Glebocki]

mglb added a comment.


  I did that, all tests pass without significant errors (only memory leaks). I am using semi-clean environment (empty directory as `$HOME` and bash as `$SHELL`). For this test I've used default configuration + blinking cursor.
  
    $ cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS=address -DBUILD_TESTING=ON ../ && make
    ...
    $ SHELL=/bin/bash HOME=fakehome ./src/autotests/TerminalInterfaceTest
    
    ********* Start testing of Konsole::TerminalInterfaceTest *********
    Config: Using QtTest library 5.9.1, Qt 5.9.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.2.0)
    PASS   : Konsole::TerminalInterfaceTest::initTestCase()
    PASS   : Konsole::TerminalInterfaceTest::testTerminalInterfaceNoShell()
    PASS   : Konsole::TerminalInterfaceTest::testTerminalInterface()
    PASS   : Konsole::TerminalInterfaceTest::cleanupTestCase()
    Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 8237ms
    ********* Finished testing of Konsole::TerminalInterfaceTest *********
    
    =================================================================
    ==22050==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 256 byte(s) in 1 object(s) allocated from:
        #0 0x7fd04c2bdb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50)
        #1 0x7fd0391c5099  (/usr/lib/x86_64-linux-gnu/libfontconfig.so.1+0x1d099)
    
    ...
  
  Can you test it with clean config + blinking? If it will work without errors, can you share the profile used by the test?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12236

To: mglb, #konsole
Cc: hindenburg, #konsole, herrold, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180419/95c85a25/attachment-0001.html>