D12238: Use libc's wcwidth() instead of own function
Mariusz Glebocki
noreply at phabricator.kde.org
Sun Apr 15 23:22:52 UTC 2018
mglb created this revision.
mglb added a reviewer: Konsole.
mglb requested review of this revision.
REVISION SUMMARY
Libc's wcwidth(), while not perfect, is used by most programs.
Implementation compatibility is necessary to avoid problems with string
width calculation and proper cursor movement.
BUG: 378124
BUG: 392171
BUG: 339439
Depends on D12236 <https://phabricator.kde.org/D12236>
TEST PLAN
Vertical lines below should align
Code Ch Source bug
U+26A1 |⚡| 378124
U+2615 |☕| 392171
U+26EA |⛪| 392171
U+1D11E |𝄞 | 339439
BRANCH
wip/Use-libcs-wcwidth-instead-of-own-function
REVISION DETAIL
https://phabricator.kde.org/D12238
AFFECTED FILES
COPYING.Unicode
src/CMakeLists.txt
src/Character.h
src/Filter.cpp
src/Screen.cpp
src/TerminalCharacterDecoder.cpp
src/TerminalDisplay.cpp
src/autotests/CharacterWidthTest.cpp
src/autotests/CharacterWidthTest.h
src/konsole_wcwidth.cpp
src/konsole_wcwidth.h
To: mglb, #konsole
Cc: #konsole
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180415/7a13f559/attachment.html>
More information about the konsole-devel
mailing list