D12236: Change internal character type size to 32 bit

[Mariusz Glebocki]

mglb created this revision.
mglb added a reviewer: Konsole.
Restricted Application added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Currently Unicode uses 0x10FFFF code points. It is possible to represent
  all of them with up to two 16 bit values (UTF-16), but this makes it
  harder to e.g. check for their width.
  
  Some test cases were changed. Originally they were added with an
  assumption that the code point will be truncated to 16 bit value and
  as a result changed to another code point.

TEST PLAN
  - All code points <= 0xFFFF should work as before
    - Start the same tmux session in two Konsoles
    - Change background to fully transparent in one of them and put it in front of the other one, so that all text will overlap
    - Generate characters with: ``` perl -XCSDL -e 'print map{chr($_), " "} 1..0xffff' ``` (you can pipe it to `fold -s | less -r`)
    - Compare output visually.
  
  - Code points > 0xFFFF should not be truncated to 16 bits
    - "𝐀" and "퐀" should be different characters
  
  - Some code points > 0xFFFF should have single width
    - Vertical lines below should align: ``` 𝐀 | 🐈| ```

REPOSITORY
  R319 Konsole

BRANCH
  wip/Change-internal-character-type-size-to-32-bit

REVISION DETAIL
  https://phabricator.kde.org/D12236

AFFECTED FILES
  src/Character.h
  src/Emulation.cpp
  src/Emulation.h
  src/ExtendedCharTable.cpp
  src/ExtendedCharTable.h
  src/Screen.cpp
  src/Screen.h
  src/TerminalCharacterDecoder.cpp
  src/TerminalDisplay.cpp
  src/Vt102Emulation.cpp
  src/Vt102Emulation.h
  src/autotests/CharacterWidthTest.cpp
  src/konsole_wcwidth.cpp
  src/konsole_wcwidth.h

To: mglb, #konsole
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180415/125ab4d4/attachment.html>