D12175: Check for valid _foregroundProcessInfo to prevent crash

Ahmad Samir noreply at phabricator.kde.org
Fri Apr 13 15:31:18 UTC 2018


ahmadsamir created this revision.
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  In Session::getUrl() check that _foregroundProcessInfo is valid before
  tyring to access its members.
  
  I couldn't reproduce the crash from the BR, but it is logical to call
  isValid() before accessing any ProcessInfo object members.
  
  BUG: 391447

REPOSITORY
  R319 Konsole

BRANCH
  foregroundprocess-pointer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12175

AFFECTED FILES
  src/Session.cpp

To: ahmadsamir
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180413/3a9f3a27/attachment.html>


More information about the konsole-devel mailing list