[konsole] [Bug 352616] konsole sometimes copies long text as a single line

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=352616

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/10a41f41b090a485b041c8
                   |                            |3b891c78aacf034f80
             Status|CONFIRMED                   |RESOLVED

--- Comment #3 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 10a41f41b090a485b041c83b891c78aacf034f80 by Kurt Hindenburg, on
behalf of Mariusz Glebocki.
Committed on 10/04/2018 at 13:33.
Pushed by hindenburg into branch 'master'.

Always preserve line breaks on "Select All" action

Summary:
`_preserveLineBreaks` was set/reset only in mousePressEvent, and was
initially disabled. This led to use of the last setting from mouse
selection, or initial value, by "Select All".

Test Plan:
* Start Konsole
* Run `seq 100`
* (optional, test should give the same effect with and without this step)
  Press {key Ctrl} and select some text
* Edit → Select All
* Copy
* Paste in any text editor

**Expected result:** text should be in multiple lines (like on
    Konsole screen)
**Actual result:** text is pasted as one line

=== Regression tests ===

* Run `seq 100`
* Select few lines using mouse
* Copy
* Paste in any text editor

**Expected result:** text should be in multiple lines (like on
   Konsole screen)

* Run `seq 100`
* Press {key Ctrl} and select few lines using mouse
* Copy
* Paste in any text editor

**Expected result:** text should be pasted as one line

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D12058

M  +1    -3    src/SessionController.cpp
M  +12   -1    src/TerminalDisplay.cpp
M  +5    -0    src/TerminalDisplay.h

https://commits.kde.org/konsole/10a41f41b090a485b041c83b891c78aacf034f80

-- 
You are receiving this mail because:
You are the assignee for the bug.