D12058: Always preserve line breaks on "Select All" action

[Mariusz Glebocki]

mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  `_preserveLineBreaks` was set/reset only in mousePressEvent, and was
  initially disabled. This led to use of the last setting from mouse
  selection, or initial value, by "Select All".
  
  BUG 352616

TEST PLAN
  - Start Konsole
  - Run `seq 100`
  - //(optional, test should give the same effect with and without this step)// Press [Ctrl] and select some text
  - Edit → Select All
  - Copy
  - Paste in any text editor
  
  **Expected result:** text should be in multiple lines (like on Konsole screen)
  **Actual result:** text is pasted as one line
  
  Regression tests
  ----------------
  
  - Run `seq 100`
  - Select few lines using mouse
  - Copy
  - Paste in any text editor
  
  **Expected result:** text should be in multiple lines (like on Konsole screen)
  
  - Run `seq 100`
  - Press [Ctrl] and select few lines using mouse
  - Copy
  - Paste in any text editor
  
  **Expected result:** text should be pasted as one line

REPOSITORY
  R319 Konsole

BRANCH
  arc/Always-preserve-line-breaks-on-Select-All-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12058

AFFECTED FILES
  src/SessionController.cpp
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h

To: mglb, #konsole
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180409/afbb4272/attachment.html>