[konsole] [Bug 392419] Line-filling trailing spaces are picked up by "copy" operation after konsole window resize.

Kurt Hindenburg bugzilla_noreply at kde.org
Sun Apr 8 00:51:55 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=392419

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kon |https://commits.kde.org/kon
                   |sole/61069543e01583644467df |sole/b7f40e0f097e8887854b79
                   |16e50f6708622aba31          |49d8b31d5521341349

--- Comment #3 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit b7f40e0f097e8887854b7949d8b31d5521341349 by Kurt Hindenburg, on
behalf of Mariusz Glebocki.
Committed on 08/04/2018 at 00:47.
Pushed by hindenburg into branch 'Applications/18.04'.

Do not resize new screen lines

Summary:
The lines are resized when something is put in them. Resizing them
here filled them with spaces (default value), later those trailing
spaces were put into history, and eventually into saved output or
clipboard (because it is assumed lines in history do not contain
trailing spaces).

Test Plan:
* Enable "Trim trailing spaces" in Profile Settings → Mouse
* Set window size to about 100x100px
* Clear terminal (Ctrl-Shift-K by default)
* Run:
```
seq $(( $(tput lines) * 2 )); \
printf '*** resize ***'; read -s; printf '\n'; \
seq $(( $(tput lines) * 2 ))
```
* When "resize" show up, resize the window to about 500x500px
* Press enter
* Select and copy lines below `*** resize ***`
* Paste it in a text editor which allows to show trailing spaces

Expected result: lines should not contain trailing spaces
Actual result: lines added when resizing the window have trailing spaces

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D11893

(cherry picked from commit 61069543e01583644467df16e50f6708622aba31)

M  +0    -3    src/Screen.cpp

https://commits.kde.org/konsole/b7f40e0f097e8887854b7949d8b31d5521341349

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the konsole-devel mailing list