D11893: Do not resize new screen lines
Mariusz Glebocki
noreply at phabricator.kde.org
Mon Apr 2 23:04:15 UTC 2018
mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
mglb requested review of this revision.
REVISION SUMMARY
The lines are resized when something is put in them. Resizing them
here filled them with spaces (default value), later those trailing
spaces were put into history, and eventually into saved output or
clipboard (because it is assumed lines in history do not contain
trailing spaces).
BUG: 392419
TEST PLAN
- Enable "Trim trailing spaces" in Profile Settings → Mouse
- Set window size to about 100x100px
- Clear terminal (Ctrl-Shift-K by default)
- Run:
seq $(( $(tput lines) * 2 )); \
printf '*** resize ***'; read -s; printf '\n'; \
seq $(( $(tput lines) * 2 ))
- When "resize" show up, resize the window to about 500x500px
- Press enter
- Select and copy lines below `*** resize ***`
- Paste it in a text editor which allows to show trailing spaces
Expected result: lines should not contain trailing spaces
Actual result: lines added when resizing the window have trailing spaces
REPOSITORY
R319 Konsole
BRANCH
wip/do-not-resize-new-screen-lines (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11893
AFFECTED FILES
src/Screen.cpp
To: mglb, #konsole
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180402/b01e63c5/attachment.html>
More information about the konsole-devel
mailing list