D8417: Use enum/QFlags to avoid boolean trap with confusing arguments

Martin Tobias Holmedahl Sandsmark noreply at phabricator.kde.org
Sun Oct 22 10:41:17 UTC 2017


sandsmark created this revision.
sandsmark added reviewers: Konsole, hindenburg.
sandsmark added a project: Konsole.

REVISION SUMMARY
  Instead of having a ton of confusing boolean arguments, use QFlags with more descriptive names than true/false.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D8417

AFFECTED FILES
  src/Emulation.cpp
  src/Screen.cpp
  src/Screen.h
  src/ScreenWindow.cpp
  src/ScreenWindow.h
  src/SessionController.cpp
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h
  src/TerminalDisplayAccessible.cpp

To: sandsmark, #konsole, hindenburg
Cc: konsole-devel, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20171022/12e72cfb/attachment-0001.html>


More information about the konsole-devel mailing list