D4975: Prevent misdetection of EOF on Linux

[Oswald Buddenhagen]

ossi added a comment.


  please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path).
  if this is a bug, does it actually affect released versions which are not being "upgraded away" on short notice? i wouldn't want a workaround for a bug that had a very short life span.

INLINE COMMENTS

> kptydevice.cpp:307
> +#else
> +        // On Linux, for some unknown reason 0 bytes can be returned after an
> +        // interrupt signal even if a slave is still attached. To avoid marking

this should be constrained more - affected versions, and the fact that it's a bug.

> kptydevice.cpp:315
> +            return true;
> +        } else if (available) {
> +            maybeEof = false;

need no else after return.

REPOSITORY
  R291 KPty

REVISION DETAIL
  https://phabricator.kde.org/D4975

To: Lekensteyn, #konsole, hindenburg, ossi
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170317/dad99fe6/attachment.html>