Review Request 130133: Fix Screen::scrollUp() behavior

[Octoploid Octoploid]

> On June 2, 2017, 7:16 a.m., Anthony Fieroni wrote:
> > src/Screen.cpp, line 763
> > <https://git.reviewboard.kde.org/r/130133/diff/2/?file=496053#file496053line763>
> >
> >     Does this should be ```_columns``` not ```_columns-1``` ?
> 
> Kurt Hindenburg wrote:
>     Has anyone had time to work on this more?  The upcoming 17.08 is near and I'd like to get this fixed by than.
> 
> Octoploid Octoploid wrote:
>     The current patch works fine for me (I use konsole with tmux daily at work).
>     So I'm not sure what more you are asking for. 
>     The patch just needs to be reviewed and then applied.
> 
> Anthony Fieroni wrote:
>     I'm not sure where lastScrolledRegion is used for, but ```_bottomMargin``` is +1, look 2 lines above, so *logically* here should be without -1, no ?
> 
> Octoploid Octoploid wrote:
>     Yes, you are right. But the problem is that I see no change in behavior, when I change _lastScrolledRegion as you have suggested. So either I don't trigger this code path in my testing, or it is neutral.
> 
> Anthony Fieroni wrote:
>     Please investigate, if lastScrolledRegion is unused, it should be removed or corrected, it does not need to leave untouch incomplete features.

OK, lastScrolledRegion is actually used (in TerminalDisplay::updateImage()). 
But the width of _lastScrolledRegion doesn't matter.
It could be any value >=1. (It cannot be 0, because otherwise region.isValid() would be false in TerminalDisplay::scrollImage)
So changing _columns-1 to _columns make absolutely no difference.


- Octoploid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130133/#review103267
-----------------------------------------------------------


On June 2, 2017, 5:44 a.m., Octoploid Octoploid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130133/
> -----------------------------------------------------------
> 
> (Updated June 2, 2017, 5:44 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 379318
>     http://bugs.kde.org/show_bug.cgi?id=379318
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Patch from Nicholas Marriott (of tmux fame).
> See: https://github.com/tmux/tmux/issues/931
> 
> Currently Screen::scrollUp() is broken and cannot be used by tmux.
> ("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround)
> 
> Fix the issue by copying the checks in Screen::scrollDown().
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 90671829bf9b 
> 
> Diff: https://git.reviewboard.kde.org/r/130133/diff/
> 
> 
> Testing
> -------
> 
> Tested with tmux trunk.
> 
> 
> Thanks,
> 
> Octoploid Octoploid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170627/c466d322/attachment-0001.html>