Review Request 130133: Fix Screen::scrollUp() behavior

Octoploid Octoploid octoploid at yandex.com
Sat Jul 1 23:16:43 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130133/
-----------------------------------------------------------

(Updated July 1, 2017, 11:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 7ff23512fd6c6af1dba87083446f85baf75e9c71 by Kurt Hindenburg to branch master.


Bugs: 379318
    http://bugs.kde.org/show_bug.cgi?id=379318


Repository: konsole


Description
-------

Patch from Nicholas Marriott (of tmux fame).
See: https://github.com/tmux/tmux/issues/931

Currently Screen::scrollUp() is broken and cannot be used by tmux.
("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround)

Fix the issue by copying the checks in Screen::scrollDown().


Diffs
-----

  src/Screen.cpp 94841a9a0b5d 

Diff: https://git.reviewboard.kde.org/r/130133/diff/


Testing
-------

Tested with tmux trunk.
I've added a new diff revision. The previous revision had an issue that the first character
on the last line was sometimes incorrectly cleared.


Thanks,

Octoploid Octoploid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170701/233831c9/attachment.html>


More information about the konsole-devel mailing list