Review Request 128396: Improvements to file matching
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sun Jan 29 14:09:21 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128396/
-----------------------------------------------------------
(Updated Jan. 29, 2017, 2:09 p.m.)
Review request for Konsole and Kurt Hindenburg.
Changes
-------
Instead of creating a new QDir and QFileInfo for every match, cache the current files with a QSet to quickly look up the filenames.
Also rebased on top of master again.
Repository: konsole
Description
-------
Include glob patterns that are either complete filenames or prefixes instead of just suffixes, also handle filenames with spaces, as `ls` has started to show them (wrapped in '').
Diffs (updated)
-----
src/Filter.h e9a31cde
src/Filter.cpp 7c0ec3ad
Diff: https://git.reviewboard.kde.org/r/128396/diff/
Testing
-------
A lot. KRegexEditor, massif, QElapsedTimer, etc.
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170129/a55eae79/attachment.html>
More information about the konsole-devel
mailing list