Review Request 129674: [Konsole] Remove pointless Desktop Actions

[Kurt Hindenburg]

> On Jan. 4, 2017, 11:59 p.m., Christoph Feck wrote:
> > There is an open bug report about this: https://bugs.kde.org/show_bug.cgi?id=373440
> > 
> > It is possibly caused by the KApplication -> QApplication port missing the needed stuff to register at DBus.
> > 
> > Instead of just removing the actions, I would have prefered investigation for this bug.

I agree - I'll revert this -at least the --new-tab part


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129674/#review101811
-----------------------------------------------------------


On Jan. 4, 2017, 3:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129674/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 3:54 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> All they do is spawn a new Konsole instance, even the --new-tab option.
> 
> 
> Diffs
> -----
> 
>   desktop/org.kde.konsole.desktop 1211810 
> 
> Diff: https://git.reviewboard.kde.org/r/129674/diff/
> 
> 
> Testing
> -------
> 
> Jump list actions currently do not enforce shell_access restriction, so by placing a Konsole launcher you can essentially bypass this by using the New Window / New Tab options.
> 
> Since the actions don't do anything special, let's remove them to avoid this easy bypass.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170128/fe22017d/attachment.html>