Review Request 129677: Pre process the -e custom command argument

Maximiliano Curia maxy at debian.org
Fri Jan 27 14:48:59 UTC 2017



> On Jan. 21, 2017, 4:24 p.m., Kurt Hindenburg wrote:
> > looks fine to me - how much testing did you do?
> 
> Kurt Hindenburg wrote:
>     do you need me to commit this for you?

Thanks for the ping, I'll push it in a couple of minutes.

Btw, the patch is already included in the Debian package, so I would say it has been tested. :)


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129677/#review102165
-----------------------------------------------------------


On Dec. 20, 2016, 2:13 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129677/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 2:13 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Special case parsing of -e, to avoid parsing parameters intended for the
> command to be executed.
> 
> 
> Diffs
> -----
> 
>   src/Application.h 8987d789b8b0789592c41ae1b0f4538f5229b64f 
>   src/Application.cpp 6256e08ccc9d57f052790550ca8f20ef3bac1716 
>   src/main.cpp 26d3da990b6aee564c0c9a237a56a65b1d372508 
> 
> Diff: https://git.reviewboard.kde.org/r/129677/diff/
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170127/762fcc04/attachment.html>


More information about the konsole-devel mailing list