Review Request 102454: When invoked from terminal, run in foreground just like other emulators

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102454/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 4:24 p.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Bugs: 262169
    http://bugs.kde.org/show_bug.cgi?id=262169


Repository: konsole


Description
-------

The current behavior of konsole is quite unique among terminal emulators. Even KDE3 konsole does not behave in this was.

This has caused some confusion and a couple of bug report. It is better to switch to the traditional way, which impose least surprise to users.

Since this change may influence many users and many scripts, better put it here for reviewing than just committing it. 

The first attached patch is more like a proof of concept, rather than a nice solution. But it works as expected.


Diffs
-----

  src/main.cpp 8da7fa1 

Diff: https://git.reviewboard.kde.org/r/102454/diff/


Testing
-------

it works fine with the problems described in bug #262169, bug #173697, bug #217357, and bug #165355.


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170121/f296c255/attachment.html>