Review Request 129786: Bug Fix: When triple click is used to select a line, the final LF should not be included.

[Aniketh Girish]

> On Jan. 10, 2017, 9:44 a.m., David Edmundson wrote:
> > src/TerminalDisplay.cpp, line 2748
> > <https://git.reviewboard.kde.org/r/129786/diff/1/?file=488776#file488776line2748>
> >
> >     if you do this then nothing will set _lineSelectionMode to true, so if this is right, it means we can clean up some other code.

So what do you mean to say? Need to keep it in the _lineSelectionMode itself or _wordSelectionMode is better ?


- Aniketh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129786/#review101921
-----------------------------------------------------------


On Jan. 8, 2017, 6:36 a.m., Aniketh Girish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129786/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 6:36 a.m.)
> 
> 
> Review request for Konsole, David Faure and Kurt Hindenburg.
> 
> 
> Bugs: 199381
>     http://bugs.kde.org/show_bug.cgi?id=199381
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> While triple clicking to select the words, it was actually selecting the line feed too. So this helps with selecting the words without selecting the line feeds.
> 
> 
> Diffs
> -----
> 
>   src/Enumeration.h a9fab40d079462c2d7eb75e9fda63c636ae92160 
>   src/Profile.cpp 61b9e34678475db344002f592cf8930087d95a0a 
>   src/TerminalDisplay.cpp 26b5012d6e7bcf448da1fcde344553594096bae9 
> 
> Diff: https://git.reviewboard.kde.org/r/129786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aniketh Girish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170110/154d865f/attachment.html>