[konsole] [Bug 374454] New: Shift left click to extend selection doesn't preserve double or triple click mode

[Glenn Coombs]

https://bugs.kde.org/show_bug.cgi?id=374454

            Bug ID: 374454
           Summary: Shift left click to extend selection doesn't preserve
                    double or triple click mode
           Product: konsole
           Version: master
          Platform: Neon Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: copy-paste
          Assignee: konsole-devel at kde.org
          Reporter: glenn.coombs at gmail.com
  Target Milestone: ---

Using the following text as an example:

Konsole is a terminal program for KDE.

Double click on the "m" in terminal to make the initial selection. The entire
word "terminal" is selected.

Now shift+left click on the "g" in program to extend the selection.  The
selection should be extended so that it is set to "terminal program".  Instead
what happens is that the selection is set to "inal prog".

I am running KDE Neon User Edition 5.8, which has Konsole version 16.12.0
installed.  After building the latest version of Konsole from git master
(version 17.03.70) I can confirm that the same issue exists in that version.

I have modified the following lines in the TerminalDisplay::mousePressEvent
function in TerminalDisplay.cpp:

        _lineSelectionMode = false;
        _wordSelectionMode = false;

so that they are only acted on if the click event has no modifier keys:

        if (!ev->modifiers()) {
                _lineSelectionMode = false;
                _wordSelectionMode = false;
        }

That fixes the behaviour for me.  It also appears to have fixed bug 346502 as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.