Review Request 129914: [terminalDisplay] Abort calculating geometry for invalid rect

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129914/#review102390
-----------------------------------------------------------


Ship it!




This is a good patch. This issue has bothered Kate for many years. I tested this patch and the black screen and unneccessary resize info widget is gone with this patch.

And not updating the size if either the width or the height is 0 (i.g. the contents rect is not valid) makes a lot of sense.

So a "Ship-It" from my side, although I'm not the maintainer. Maybe wait for another +1 before you commit.

- Dominik Haumann


On Feb. 4, 2017, 7:57 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129914/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2017, 7:57 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Reflect in Kate Konsole part see https://git.reviewboard.kde.org/r/129903/
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp dd911779 
> 
> Diff: https://git.reviewboard.kde.org/r/129914/diff/
> 
> 
> Testing
> -------
> 
> Yup
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170204/f9fe1c6c/attachment-0001.html>