Review Request 129912: Implemented new property() method of TerminalInterface

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Feb 4 20:01:22 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129912/#review102389
-----------------------------------------------------------



W/o testing, it looks fine - Martin, any comments?

- Kurt Hindenburg


On Feb. 3, 2017, 5:26 p.m., Sven Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129912/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 5:26 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> To enable TerminalInterface consumers to get the properties of the Konsole part
> (e.g. the setting StartInCurrentSessionDir), this method was introduced.
> 
> 
> Diffs
> -----
> 
>   src/Part.h bbe65106aa9789f9d6d8fcdec0a9a34a2ddbcf60 
>   src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d 
> 
> Diff: https://git.reviewboard.kde.org/r/129912/diff/
> 
> 
> Testing
> -------
> 
> Locally compile konsole with the new method, and running a yakuake instance against the patched konsole.
> 
> 
> Thanks,
> 
> Sven Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170204/15a7a602/attachment.html>


More information about the konsole-devel mailing list