Review Request 129914: [terminalDisplay] Abort calculating geometry for invalid rect

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129914/#review102386
-----------------------------------------------------------



I wonder if we should try to get a valid _contentRect before returning. leaving an invalid _contentRect doesn't seem a good idea.

- Kurt Hindenburg


On Feb. 3, 2017, 5:59 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129914/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 5:59 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Reflect in Kate Konsole part see https://git.reviewboard.kde.org/r/129903/
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp dd911779 
> 
> Diff: https://git.reviewboard.kde.org/r/129914/diff/
> 
> 
> Testing
> -------
> 
> Yup
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170204/79cfb200/attachment.html>