Review Request 129214: Added possibility to give default dir on Part instantiation
Sven Fischer
sven at leiderfischer.de
Fri Feb 3 17:17:51 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129214/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 5:17 nachm.)
Status
------
This change has been discarded.
Review request for Konsole.
Repository: konsole
Description
-------
On konsole KPart instantiation, the QVariantList is evaluated for a
default directory to change to. The Part honors the profile setting "Use
same directory...". If it is not set, the directory is ignored.
Simplified the argument parsing
Beautified the source by using C++11 iteration and QVariantMap
Diffs
-----
src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d
Diff: https://git.reviewboard.kde.org/r/129214/diff/
Testing
-------
Built a new version of yakuake against this konsolepart.so. Worked perfectly.
Thanks,
Sven Fischer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170203/09b72add/attachment.html>
More information about the konsole-devel
mailing list