D9448: Fix messed up menus after closing a detached tab

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: hindenburg.
ahmadsamir created this object with edit policy "Administrators".
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.

REVISION SUMMARY
  This should fix Bug 348478 [1].
  
  To reproduce the issue:
  
  - open a konsole window and open more than one tab
  - detach one of them
  - close the detached tab
  - try to use e.g. the Edit menu, it doesn't work
  
  The issue is that _pluggedController in sessionFinished() after closing the detached tab doesn't point to the SessionController of the "session" from the sender, but actually points to the SessionController of the session of  the tab that's active in the original window; so calling unplugController on it messes up the menus.
  
  [1] https://bugs.kde.org/show_bug.cgi?id=348478

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D9448

AFFECTED FILES
  src/ViewManager.cpp

To: ahmadsamir, hindenburg
Cc: #konsole, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20171221/8f175506/attachment.html>