D8610: Fix for some fonts not rendering in bold/italic

[René J.V. Bertin]

rjvbb added a comment.


  In https://phabricator.kde.org/D8610#164604, @jackkiefer wrote:
  
  > In https://phabricator.kde.org/D8610#164594, @hindenburg wrote:
  >
  > > This does seem like a work around - is this really the best way to handle this?
  >
  >
  > I honestly haven't any idea. This bug has been troubling me for months, and this fix finally brought my bold fonts back, so I'm personally quite happy!
  
  
  Konsole uses the `QFontDialog` font selector dialog. Starting with Qt 5.8 (I think) this always sets the style name on the returned QFont instance. There is some disagreement among Qt devs whether this is a bug or a necessary feature so the safe thing to assume here is that the style name will continue to be set. AFAICS that's the only safe way forward which will give the intended/expected behaviour with all supported Qt versions.
  
  That leaves 3 options:
  1 use KFontRequester instead (which will supposedly be fixed)
  2 use the current workaround
  3 use a more elegant workaround that takes the QFont returned by the QFontDialog, constructs the equivalent QFont *without* stylename and uses that font instead.
  
  Solution 1) would be the best if it weren't for the fact that it'll still need option 2 or 3 to give the expected behaviour with all supported KF5 and Qt5 versions.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D8610

To: jackkiefer, #konsole
Cc: rjvbb, hindenburg, cfeck, konsole-devel, ngraham, #konsole
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20171217/67e9ce34/attachment.html>