Review Request 129217: Fix re-parsing of command line arguments

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Oct 22 19:31:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129217/#review100209
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On Oct. 18, 2016, 10:08 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129217/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 10:08 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> If a new Konsole instance is launched via DBus (e. g. single process mode), it re-used the QCommandLineParser each time, so each new instance would inherit all parsed options.
> 
> Most noticeably is if you have konsole running, press Shift+F4 in Dolphin to launch a Konsole instance in the current folder (which leads Konsole to use a temporary profile), and then try to open a new konsole instance outside of that, it would open in the folder from Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/Application.h 2c606b1 
>   src/Application.cpp e903981 
>   src/main.cpp 29f6f2b 
> 
> Diff: https://git.reviewboard.kde.org/r/129217/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161022/54a03447/attachment.html>


More information about the konsole-devel mailing list