Review Request 128828: Make URL and file filtering individually configurable

[Kurt Hindenburg]

> On Sept. 4, 2016, 6:17 p.m., Kurt Hindenburg wrote:
> > What do you think about putting the Advanced->Show URL hints when... in the Mouse tab under the Underline options
> > 
> > I think some the Mouse options should be horizontal by oh well
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Yeah, I was thinking about the same. I think maybe we should put all the hint-stuff in a separate groupbox or something, on the same page.
> 
> Kurt Hindenburg wrote:
>     Are you still working on this? It looks like the next freeze will be in mid Nov.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Sorry, completely forgot this, can I do the re-doing of the settings UI in a separate change? To keep this as small as possible.

Yes that's fine


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128828/#review98881
-----------------------------------------------------------


On Sept. 4, 2016, 3:56 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128828/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2016, 3:56 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 368234
>     http://bugs.kde.org/show_bug.cgi?id=368234
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Make it possible to select either just file filtering or URL filtering.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h bb2896f 
>   src/EditProfileDialog.cpp ec3216a 
>   src/EditProfileDialog.ui 8358bd3 
>   src/Profile.h 84a0acc 
>   src/Profile.cpp a8cec60 
>   src/SessionController.h 3ac06f5 
>   src/SessionController.cpp a1db8bc 
>   src/TerminalDisplay.h b3ffba7 
>   src/TerminalDisplay.cpp 3c4364c2d 
>   src/ViewManager.cpp ba3b72e 
> 
> Diff: https://git.reviewboard.kde.org/r/128828/diff/
> 
> 
> Testing
> -------
> 
> Tested turning both on and off, testing that it is updated when editing config.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161015/128659c7/attachment.html>