Review Request 129376: Let users configure the default search settings in konsole

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129376/#review100944
-----------------------------------------------------------



Thanks - it looks good enough to put in - we are close to the cut-off for new strings for 16.12

Typically you'd want any changes in the Settings and actual search widget to be saved

- Kurt Hindenburg


On Nov. 11, 2016, 2 p.m., Ahmad Samir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129376/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2016, 2 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 332601
>     http://bugs.kde.org/show_bug.cgi?id=332601
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This patch should make it possible to configure the default search settings in konsole. This can be done from the "Configure Konsole" dialogue from the General tab using a new section titled "Default Search Settings". Users should be able to configure:
> - Whether the search is case sensitive (off by default)
> - Whether regular expressions are used to search (off by default)
> - Whether to highlight all search matches (on by default)
> - The search direction whether to search from the bottom of the output to the top or vice-versa (on by default).
> 
> I kept the same default search settings as before.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e7891f7 
>   src/IncrementalSearchBar.cpp 17a14ca 
>   src/settings/GeneralSettings.ui 8d19101 
>   src/settings/konsole.kcfg 075d2f7 
> 
> Diff: https://git.reviewboard.kde.org/r/129376/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ahmad Samir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161119/4af6c5fa/attachment.html>