Review Request 129368: Breeze color scheme uses better contrasting color for "black" color value

[Jens Reuterberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129368/#review100760
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Reuterberg


On Nov. 10, 2016, 11:04 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129368/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 11:04 a.m.)
> 
> 
> Review request for Konsole and Jens Reuterberg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The previous set of blueish colors offered fairly bad contrast with the
> charcoal grey background when using the "black" contrast value. To give
> a more uniform experience the default "black" color is now charcoal grey
> with it's intense variant shifted into a light grey to complement the
> intense background, which is charcoal grey shifted into a more intense dark
> 
> This should offer overall better contrast, in particular in htop.
> 
> BUG: 371068
> REVIEW:
> CHANGELOG: Breeze color scheme uses better contrasting color for "black" color value
> 
> 
> Diffs
> -----
> 
>   data/color-schemes/Breeze.colorscheme e19c4515adc82f6d99bdbc55e9abc993b94c7031 
> 
> Diff: https://git.reviewboard.kde.org/r/129368/diff/
> 
> 
> Testing
> -------
> 
> ![](http://i.imgur.com/bbRV061.png)
> ![](http://i.imgur.com/2BfsXmS.png)
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161110/13a38bbc/attachment.html>