Review Request 129214: Added possibility to give default dir on Part instantiation

[Martin Tobias Holmedahl Sandsmark]

> On Nov. 7, 2016, 7:26 p.m., Kurt Hindenburg wrote:
> > Thanks - can you answer Martin's question and provide the yakuake code that is calling this?  I don't object to the code, I want to double-check what you're doing.
> 
> Sven Fischer wrote:
>     Hi Kurt,
>     
>     I thought I had answered the question, but obviously it doesn't show up here...
>     
>     For the code: Please have a look at https://git.reviewboard.kde.org/r/129215/diff/1#index_header, file app/terminal.cpp. The Part is instantiated by 
>     
>     factory = KPluginLoader(service->library()).factory(); 
>     
>     and then
>     
>     m_part = factory ? (factory->create<KParts::Part>(parent, defaults)) : 0;
>     
>     So the defaults parameter is the one to use - in yakuake there is no direct inclusion of the Part header, which is indeed the idea behind the PluginLoader factory. That's the reason why I'm not able to use createSession.

Maybe use the existing TerminalInterface::showShellInDir() instead? Or extend TerminalInterface? I just don't like using opaque QVariant maps with arbitrary strings...


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129214/#review100697
-----------------------------------------------------------


On Oct. 27, 2016, 6:44 a.m., Sven Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129214/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 6:44 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> On konsole KPart instantiation, the QVariantList is evaluated for a
> default directory to change to. The Part honors the profile setting "Use
> same directory...". If it is not set, the directory is ignored.
> 
> Simplified the argument parsing
> 
> Beautified the source by using C++11 iteration and QVariantMap
> 
> 
> Diffs
> -----
> 
>   src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d 
> 
> Diff: https://git.reviewboard.kde.org/r/129214/diff/
> 
> 
> Testing
> -------
> 
> Built a new version of yakuake against this konsolepart.so. Worked perfectly.
> 
> 
> Thanks,
> 
> Sven Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161109/1c8bcf5e/attachment.html>